Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new internal in-memory representation and implementations #478

Closed
5 of 6 tasks
tigrannajaryan opened this issue Jan 3, 2020 · 0 comments
Closed
5 of 6 tasks

Add new internal in-memory representation and implementations #478

tigrannajaryan opened this issue Jan 3, 2020 · 0 comments

Comments

@tigrannajaryan
Copy link
Member

tigrannajaryan commented Jan 3, 2020 •
edited by bogdandrutu
Loading

Internal representation of traces and metrics currently uses OpenCensus Protobuf structs.

We want to convert to OTLP Protobuf-based structs internally. Here is how we can do this gradually:

  • Introduce parallel OTLP-based data types for traces and metrics.
  • Introduce new set of exporter/receiver/processor interfaces which can work with OTLP-based data types.
  • During startup if all components in a pipeline implement the extended OTLP-based interfaces enable otlp mode that uses OTLP-based structs and interfaces for internal data passing.
  • Gradually add support of OTLP-based interfaces to all existing components.
  • Add shims that convert between OC and OTLP-based interfaces and automatically convert the data in the pipeline when mixed components are used.
  • Optionally: retire old OpenCensus based code, assuming that all components in this repo and in contrib repo were converted.
This was referenced Jan 3, 2020
Closed
Closed
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Feb 5, 2020
Add OTLP trace data types, factories and helpers
2e4ad11 
This is step one in converting in-memory representation from OC to OTLP.
This change has no effect since introduced types are not used anywhere
in active code.

Issue: open-telemetry#478
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Feb 5, 2020
Add OTLP trace data types, factories and helpers
207c0bb 
This is step one in converting in-memory representation from OC to OTLP. This
change has no effect except in tests. The introduced code is not is not reachable.

Issue: open-telemetry#478
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Feb 5, 2020
Add OTLP trace data types, factories and helpers
4cb6e5c 
This is step one in converting in-memory representation from OC to OTLP. This
change has no effect except in tests. The introduced code is not is not reachable.

Issue: open-telemetry#478
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Feb 5, 2020
Add OTLP trace data types, factories and helpers
04c056d 
This is step one in converting in-memory representation from OC to OTLP. This
change has no effect except in tests. The introduced code is not is not reachable.

Issue: open-telemetry#478
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Feb 5, 2020
Add OTLP trace data types, factories and helpers
4d0cbaf 
This is step one in converting in-memory representation from OC to OTLP. This
change has no effect except in tests. The introduced code is not is not reachable.

Issue: open-telemetry#478
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Feb 5, 2020
Add OTLP trace data types, factories and helpers
34420b5 
This is step one in converting in-memory representation from OC to OTLP. This
change has no effect except in tests. The introduced code is not is not reachable.

Issue: open-telemetry#478
@tigrannajaryan tigrannajaryan mentioned this issue Feb 5, 2020
Merged
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Feb 5, 2020
Add OTLP trace data types, factories and helpers
9aac7c6 
This is step one in converting in-memory representation from OC to OTLP. This
change has no effect except in tests. The introduced code is not reachable.

Issue: open-telemetry#478
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Feb 6, 2020
Add OTLP trace data types, factories and helpers
8601926 
This is step one in converting in-memory representation from OC to OTLP. This
change has no effect except in tests. The introduced code is not reachable.

Issue: open-telemetry#478
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Feb 6, 2020
Add OTLP trace data types, factories and helpers
df8503c 
This is step one in converting in-memory representation from OC to OTLP. This
change has no effect except in tests. The introduced code is not reachable.

Issue: open-telemetry#478
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Feb 10, 2020
Add OTLP trace data types, factories and helpers
ab9eea2 
This is step one in converting in-memory representation from OC to OTLP. This
change has no effect except in tests. The introduced code is not reachable.

Issue: open-telemetry#478
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Feb 10, 2020
Add OTLP trace data types, factories and helpers
4f01eb6 
This is step one in converting in-memory representation from OC to OTLP. This
change has no effect except in tests. The introduced code is not reachable.

Issue: open-telemetry#478
tigrannajaryan added a commit that referenced this issue Feb 11, 2020
@tigrannajaryan
Add OTLP trace data types, factories and helpers (#534)
4da23d1 
This is step one in converting in-memory representation from OC to OTLP. This
change has no effect except in tests. The introduced code is not reachable.

Issue: #478
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Feb 13, 2020
Add OC to OTLP translation functions
8a0b1c1 
This implements OC to OTLP protobuf message translation.
The code is currently reachable only from the tests.

We probably need a bit more coverage for this code but I am
submitting this change as is for the sake of keeping the
size of the PR managable for reviewing.

Contributes to open-telemetry#478
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Feb 13, 2020
Add OC to OTLP translation functions
281a835 
This implements OC to OTLP protobuf message translation.
The code is currently reachable only from the tests.

We probably need a bit more coverage for this code but I am
submitting this change as is for the sake of keeping the
size of the PR managable for reviewing.

Contributes to open-telemetry#478
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Feb 13, 2020
Add OC to OTLP translation functions
4f9a097 
This implements OC to OTLP protobuf message translation.
The code is currently reachable only from the tests.

We probably need a bit more coverage for this code but I am
submitting this change as is for the sake of keeping the
size of the PR managable for reviewing.

Contributes to open-telemetry#478
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Feb 13, 2020
Add OC to OTLP translation functions
ff85dd3 
This implements OC to OTLP protobuf message translation.
The code is currently reachable only from the tests.

We probably need a bit more coverage for this code but I am
submitting this change as is for the sake of keeping the
size of the PR managable for reviewing.

Contributes to open-telemetry#478
@tigrannajaryan tigrannajaryan mentioned this issue Feb 13, 2020
Merged
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Feb 13, 2020
Add OC to OTLP translation functions
ad4ffba 
This implements OC to OTLP protobuf message translation.
The code is currently reachable only from the tests.

We probably need a bit more coverage for this code but I am
submitting this change as is for the sake of keeping the
size of the PR managable for reviewing.

Contributes to open-telemetry#478
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Feb 13, 2020
Add OC to OTLP translation functions
7b1c6ed 
This implements OC to OTLP protobuf message translation.
The code is currently reachable only from the tests.

We probably need a bit more coverage for this code but I am
submitting this change as is for the sake of keeping the
size of the PR managable for reviewing.

Contributes to open-telemetry#478
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Feb 13, 2020
Add OC to OTLP translation functions
257516a 
This implements OC to OTLP protobuf message translation.
The code is currently reachable only from the tests.

We probably need a bit more coverage for this code but I am
submitting this change as is for the sake of keeping the
size of the PR managable for reviewing.

Contributes to open-telemetry#478
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Feb 13, 2020
Add OC to OTLP translation functions
8681bb8 
This implements OC to OTLP protobuf message translation.
The code is currently reachable only from the tests.

We probably need a bit more coverage for this code but I am
submitting this change as is for the sake of keeping the
size of the PR managable for reviewing.

Contributes to open-telemetry#478
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Feb 13, 2020
Add OC to OTLP translation functions
10ad229 
This implements OC to OTLP protobuf message translation.
The code is currently reachable only from the tests.

We probably need a bit more coverage for this code but I am
submitting this change as is for the sake of keeping the
size of the PR managable for reviewing.

Contributes to open-telemetry#478
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Feb 14, 2020
Add OC to OTLP translation functions
d6c6e25 
This implements OC to OTLP protobuf message translation.
The code is currently reachable only from the tests.

We probably need a bit more coverage for this code but I am
submitting this change as is for the sake of keeping the
size of the PR managable for reviewing.

Contributes to open-telemetry#478
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Feb 14, 2020
Add OC to OTLP translation functions
4f87c73 
This implements OC to OTLP protobuf message translation.
The code is currently reachable only from the tests.

We probably need a bit more coverage for this code but I am
submitting this change as is for the sake of keeping the
size of the PR managable for reviewing.

Contributes to open-telemetry#478
tigrannajaryan added a commit that referenced this issue Feb 18, 2020
@tigrannajaryan
Add OC to OTLP translation functions (#546)
dae8035 
This implements OC to OTLP protobuf message translation.
The code is currently reachable only from the tests.

We probably need a bit more coverage for this code but I am
submitting this change as is for the sake of keeping the
size of the PR managable for reviewing.

Contributes to #478
@tigrannajaryan tigrannajaryan changed the title Add OTLP-based internal implementations Add new internal in-memory representation and implementations Mar 12, 2020
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Mar 12, 2020
Add the rest of V2 factories and interfaces
19899c8 
- Added V2 metric factories and interfaces for receivers and exporters.
- Added V2 factories and interfaces for processors.

All changes are uniform with previously introduced initial batch of
V2 factories and interfaces.

Issue: open-telemetry#478
@tigrannajaryan tigrannajaryan mentioned this issue Mar 12, 2020
Merged
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Mar 12, 2020
Add the rest of V2 factories and interfaces
d362a2b 
- Added V2 metric factories and interfaces for receivers and exporters.
- Added V2 factories and interfaces for processors.

All changes are uniform with previously introduced initial batch of
V2 factories and interfaces.

Issue: open-telemetry#478
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Mar 16, 2020
Add the rest of V2 factories and interfaces
6192018 
- Added V2 metric factories and interfaces for receivers and exporters.
- Added V2 factories and interfaces for processors.

All changes are uniform with previously introduced initial batch of
V2 factories and interfaces.

Issue: open-telemetry#478
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Mar 16, 2020
Add the rest of V2 factories and interfaces
d797833 
- Added V2 metric factories and interfaces for receivers and exporters.
- Added V2 factories and interfaces for processors.
- Creation methods in V2 factories accept a CreationParams struct to
  allow for easier addition of new parameters in the future without
  breaking the interface.

All changes are uniform with previously introduced initial batch of
V2 factories and interfaces (except introduction of CreationParams).

Issue: open-telemetry#478
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Mar 16, 2020
Add the rest of V2 factories and interfaces
763713b 
- Added V2 metric factories and interfaces for receivers and exporters.
- Added V2 factories and interfaces for processors.
- Creation methods in V2 factories accept a CreationParams struct to
  allow for easier addition of new parameters in the future without
  breaking the interface.

All changes are uniform with previously introduced initial batch of
V2 factories and interfaces (except introduction of CreationParams).

Issue: open-telemetry#478
tigrannajaryan added a commit that referenced this issue Mar 16, 2020
@tigrannajaryan
Add the rest of V2 factories and interfaces (#626)
98973e7 
- Added V2 metric factories and interfaces for receivers and exporters.
- Added V2 factories and interfaces for processors.
- Creation methods in V2 factories accept a CreationParams struct to
  allow for easier addition of new parameters in the future without
  breaking the interface.

All changes are uniform with previously introduced initial batch of
V2 factories and interfaces (except introduction of CreationParams).

Issue: #478
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
@krnowak @jmacd
Fix a possible nil-dereference crash (open-telemetry#478)
29cd0c0 
* Test for a panic inside global internal meter instrument's Unbind

* Fix a possible nil-dereference crash

There is a nil dereference crash if we perform some operations in
certain order:

- get a global meter
- create an instrument
- bind it
- set the delegate
- unbind the instrument
- call some recording function on the not-really-bound-anymore
  instrument

Unbind will run the no op run-once initialization routine, so the
follow-up RecordOne call will not run it's initialization
routine. Which RecordOne's initialization routine being skipped, the
delegate to bounded instrument is not set, but the code is still
trying to get a pointer to it and then unconditionally dereference it.

Add an extra check for a nil pointer - if this is true, then Unbind
was first and RecordOne should effectively be a no op.

Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
@jeffreyc-splunk
Automate puppet release (open-telemetry#478)
9f321a2 
* Add blacksmith to Rakefile and update deps

* Update RELEASE.md and scripts

* Add puppet-release to .gitlab-ci.yml

* Add github workflow to push puppet release tag

* Update puppet dev-image to ruby:2.6-buster
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
@ThomsonTan
Add explicit conversion from size_t to int for shared_ptr_test (open-…
b5f0968 
…telemetry#478)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bogdandrutu @tigrannajaryan