Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReadHeaderTimeout values #5699

Closed
codeboten opened this issue Jul 18, 2022 · 0 comments · Fixed by #10675
Closed

Add ReadHeaderTimeout values #5699

codeboten opened this issue Jul 18, 2022 · 0 comments · Fixed by #10675
Labels
release:required-for-ga Must be resolved before GA release

Comments

@codeboten
Copy link
Contributor

The following lint errors started showing up after the latest upgrade to golangci-lint:

golangci-lint run
config/confighttp/confighttp.go:321:10: G112: Potential Slowloris Attack because ReadHeaderTimeout is not configured in the http.Server (gosec)
        return &http.Server{
                Handler: handler,
        }, nil
config/confighttp/compression_test.go:106:12: G112: Potential Slowloris Attack because ReadHeaderTimeout is not configured in the http.Server (gosec)
                        srv := &http.Server{
                                Handler: handler,
                        }
config/confighttp/compression_test.go:204:12: G112: Potential Slowloris Attack because ReadHeaderTimeout is not configured in the http.Server (gosec)
                        srv := &http.Server{
                                Handler: httpContentDecompressor(handler),
                        }
make: *** [lint] Error 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment