Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Go 1.19 sync/atomic wrappers instead of go.uber.org/atomic #7160

Closed
mx-psi opened this issue Feb 8, 2023 · 5 comments
Closed

Use Go 1.19 sync/atomic wrappers instead of go.uber.org/atomic #7160

mx-psi opened this issue Feb 8, 2023 · 5 comments
Assignees
@patil-kshitij
Labels
area:miscellaneous easy Complexity: Easy enhancement New feature or request good first issue Good for newcomers priority:p2 Medium

Comments

@mx-psi
Copy link
Member

mx-psi commented Feb 8, 2023 •
edited by codeboten
Loading

Go 1.19 includes new builtin atomic wrappers that can replace the usage of go.uber.org/atomic. We should switch to using these and ban the usage of go.uber.org/atomic via depguard (basically, inverting this).

This was blocked by #7159
@mx-psi mx-psi added enhancement New feature or request good first issue Good for newcomers priority:p2 Medium area:miscellaneous easy Complexity: Easy on hold labels Feb 8, 2023
@mx-psi mx-psi mentioned this issue Feb 8, 2023
Closed
@mx-psi
Copy link
Member Author

mx-psi commented Feb 15, 2023

This is now unblocked

@mx-psi mx-psi removed the on hold label Feb 15, 2023
@patil-kshitij
Copy link
Contributor

Can I please take ownership for this ?

@mx-psi
Copy link
Member Author

mx-psi commented Feb 16, 2023

@patil-kshitij all yours :)

@patil-kshitij patil-kshitij mentioned this issue Feb 20, 2023
Merged
@patil-kshitij
Copy link
Contributor

PR for this issue is raised.

#7220

codeboten pushed a commit that referenced this issue Mar 5, 2023
@patil-kshitij
replacing go.uber.org/atomic by sync/atomic (#7220)
5c58fb3 
replacing go.uber.org/atomic by sync/atomic
wrt issue #7160
@codeboten
Copy link
Contributor

Fixed by #7220

@zchee zchee mentioned this issue Mar 10, 2023
Closed
@jefchien jefchien mentioned this issue Mar 14, 2023
Merged
@mx-psi mx-psi mentioned this issue Aug 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patil-kshitij patil-kshitij

Labels
area:miscellaneous easy Complexity: Easy enhancement New feature or request good first issue Good for newcomers priority:p2 Medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@codeboten @mx-psi @patil-kshitij