-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[admin] Validate version format in release workflow #7627
Comments
I want to work on this. |
Assigned to you @Abhishek-569 :) |
Thanks. @mx-psi is there any place to learn on how to add validation in a workflow? |
Github does not have any form of input validation built-in, so you will have to add a new step to this job
|
okay thanks. |
We ran into this on v0.82.0 as well |
I'd like to work on this. |
Hey @mx-psi I would like to take over this issue, I'll try to open PR very you assign this to me for sure. |
**Description:** <Describe what has changed.> enhance the "Automation - Prepare Release" GitHub Actions workflow by adding version format validation. The workflow now includes a new job, "validate-version," which checks whether the provided version inputs match the expected schema **Link to tracking Issue:** <Issue number if applicable> #7627 --------- Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Thanks for fixing this @Sanket-0510 ! |
My pleasure ❤️❤️✨ |
We don't do any validation on the version introduced for the
prepare-release
workflow, but we have some restrictions on the version format as documented here:opentelemetry-collector/.github/workflows/prepare-release.yml
Lines 3 to 22 in 2c132fa
We should add some validation to make the release workflow fail fast if the tags don't match the expected schema.
Relates to #7576
The text was updated successfully, but these errors were encountered: