Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update InitMetricReader to avoid returning server #8045

Open
codeboten opened this issue Jul 10, 2023 · 0 comments
Open

update InitMetricReader to avoid returning server #8045

codeboten opened this issue Jul 10, 2023 · 0 comments

Comments

@codeboten
Copy link
Contributor

A follow up to #7871, the InitMetricReader method could be refactored to clean up the args and return values. See the comment:

// server returned here only happens when a pull based metric
// reader is configured, this could be refactored to pass in a
// func to add the server to the list of servers. another thing that would
// be nice is not to have to pass down the asyncErrorChannel

Originally posted by @mx-psi in #7871 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant