[wip] add ability to configure prometheus export via readers
#7871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
changed the title
metric_readersmetric_readers
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #7871 +/- ##
==========================================
- Coverage 90.60% 90.53% -0.08%
==========================================
Files 301 301
Lines 15209 15291 +82
==========================================
+ Hits 13780 13843 +63
- Misses 1148 1162 +14
- Partials 281 286 +5
☔ View full report in Codecov by Sentry. |
codeboten
force-pushed
the
codeboten/may-29-otlp-export
branch
4 times, most recently
from
2c8df44
to
d8af4ab
Compare
mx-psi
reviewed
Jun 23, 2023
codeboten
force-pushed
the
codeboten/may-29-otlp-export
branch
from
fa24823
to
72e9446
Compare
codeboten
force-pushed
the
codeboten/may-29-otlp-export
branch
from
72e9446
to
f8cc8c8
Compare
codeboten
changed the title
metric_readersreaders
codeboten
commented
Jul 10, 2023
mx-psi
approved these changes
Jul 10, 2023
codeboten
force-pushed
the
codeboten/may-29-otlp-export
branch
from
87232cb
to
b720440
Compare
TylerHelmuth
approved these changes
Jul 11, 2023
codeboten
force-pushed
the
codeboten/may-29-otlp-export
branch
3 times, most recently
from
912a4e9
to
be90fe8
Compare
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
added 3 commits
July 13, 2023 14:04
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
force-pushed
the
codeboten/may-29-otlp-export
branch
from
a329faf
to
69ff4c3
Compare
dmitryax
pushed a commit
that referenced
this pull request
Jun 28, 2024
…10343) #### Description Fixing the bug: the latest version of otel-collector failed to start with ipv6 metrics endpoint service telemetry. This problem began to occur after #9037 with the feature gate flag enabled was merged. This problem is probably an implementation omission because the enabled codepath, which was originally added by #7871, is marked as WIP. You can reproduce the issue with the config and the environment variable (`MY_POD_IP=::1`). ```yaml service: telemetry: logs: encoding: json metrics: address: '[${env:MY_POD_IP}]:8888' ``` #### Link to tracking issue Fixes #10011 --------- Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables end users to configure additional prometheus exporters for the collector's telemetry
via the
readersconfiguration option. Configuring prometheus through the existing methodof setting the service::metrics::address will continue to work, and only log a warning for users
who have enabled the
telemetry.useOtelWithSDKConfigurationForInternalTelemetryfeature gate.Linked issue: #7641
This is a follow up to #7679