-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metric_readers section name could be shortened to readers #20
Comments
The name metric_reader was chosen as a way to remain consistent w/ the definition in the specification. After reviewing some of the other fields in the current configuration, it is clear that there are currently inconsistencies already. For example exporter under the After a discussion in the working group call this morning, the proposal is to drop the following prefixes under each provider:
This would allow us to create a consistent rule to make expectations clear for users. WDYT @mx-psi? |
@codeboten That makes sense to me 👍 In all cases in the current schema I believe everything is still readable while being shorter after dropping those prefixes |
Closes open-telemetry#20 Signed-off-by: Alex Boten <aboten@lightstep.com>
Closes #20 --------- Signed-off-by: Alex Boten <aboten@lightstep.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
TL;DR
The
metric_readers
section can be shortened toreaders
which would be shorter while still being readable and concrete enough, and would make the OpenTelemetry Collector telemetry configuration cleaner.Longer explanation & context
On open-telemetry/opentelemetry-collector/pull/7871 we are using the Configuration WG's
meter_provider
configuration schema as part of the OpenTelemetry Collector telemetry configuration. In this case, configuring a reader looks like the following:As noted, this matches the example on this repository:
opentelemetry-configuration/kitchen-sink-example.yaml
Lines 64 to 69 in 362b23e
Although I believe in our case it is specially more salient because our top level configuration is named
metrics
, I still think on the base example on this repository themetric_
prefix for themetric_readers
subsection is redundant: a meter provider will presumably never have any other kind of reader.The text was updated successfully, but these errors were encountered: