Leaking goroutine in memorylimiterprocessor

[jskiba]

Describe the bug
Memorylimiter processor never leaves that loop https://github.com/open-telemetry/opentelemetry-collector/blob/1d0d1ef21baebfcc9ed1d67f0237437ceb9a0049/processor/memorylimiterprocessor/memorylimiter.go#L230C1-L230C1. In result this goroutine or many of them leak every time after shutdown procedure.

Steps to reproduce
jskiba@2f8ee15
The only leaking goroutine is the one from this bug #8945.

What did you expect to see?
No leaking goroutine and correct exit from for loop.

What did you see instead?
Goroutine

opentelemetry-collector/processor/memorylimiterprocessor/memorylimiter.go

Line 229 in 1d0d1ef

go func() {

never exits. When a ticker is stopped it does not return information that it was closed, different mechanism should be used.

What version did you use?
1d0d1ef

What config did you use?
not applicable

Environment
OS: Debian 12.4 bookworm
Compiler(if manually compiled): go 1.21.5"

Additional context

[dmitryax]

@jskiba thanks for reporting. Do you have a chance to help with a PR?

[jskiba]

@dmitryax it's already approved #9100