Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set gomaxprocs and gomemlimit automatically based on cgroup limits #9203

Closed
tomershafir opened this issue Jan 2, 2024 · 5 comments
Closed
Labels
area:miscellaneous enhancement New feature or request

Comments

@tomershafir
Copy link

Use https://github.com/uber-go/automaxprocs and https://github.com/KimMachineGun/automemlimit or implement alike for non-lib otelcol

@mx-psi
Copy link
Member

mx-psi commented Jan 3, 2024

@tomershafir Would this be feasible to have as an extension?

@tomershafir
Copy link
Author

tomershafir commented Jan 3, 2024

@mx-psi yes, it seems like the extension model fits. How would you think to address this, import the libs as dependencies or copy-update their source code?

@mx-psi
Copy link
Member

mx-psi commented Jan 4, 2024

@tomershafir Importing the libs would work for me. I think this can be an extension in opentelemetry-collector-contrib, I would be happy to sponsor it. Can you file a new component proposal in contrib? You can add me on the sponsor field, and we can let other people on the community comment on the idea first :)

@tomershafir
Copy link
Author

@mx-psi done open-telemetry/opentelemetry-collector-contrib#30289

@mx-psi
Copy link
Member

mx-psi commented Jan 9, 2024

Helm chart maintainers agree the proposed extension is a good idea, so I am going to close this one and we can continue the discussion and development over at open-telemetry/opentelemetry-collector-contrib#30289

@mx-psi mx-psi closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:miscellaneous enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants