Fix Prepare release workflow #9748
Labels
bug
Something isn't working
ci-cd
CI, CD, testing, build issues
help wanted
Good issue for contributors to OpenTelemetry Service to pick up
Comments
dmitryax
added
bug
|
@dmitryax I submitted a fix for this issue. Will also apply the fix to the collector-contrib repo (after this one is approved), which seems to have the same issue. |
mx-psi
pushed a commit
that referenced
this issue
Jul 22, 2024
) #### Description This PR fixes an issue where the `.` character in a version string (e.g. `1.2.3`) was interpreted by `sed` as any character and therefore needed to be properly escaped. This happened during the prepare-release workflow. The version string for the current stable and current beta version strings provided at pipeline start is replaced as follows: ``` 1.2.3 -> 1[.]2[.]3 ``` This ensures that `sed` searches for the literal `.` character instead of interpreting it as a wildcard character. I specifically used the `[]` syntax to avoid the hassle of "how many backslashes do i need until it's properly escaped?". (and that for bash and sed, which work different on different OSes anyways which makes it hard to test as well) #### Link to tracking issue Fixes #9748 Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To avoid regex replacements like 998f64d#diff-c7c8156618a7f8126b25ca1bdfde3e172a0d2cb75c533d63a71617ae2a5c54aeR198
The text was updated successfully, but these errors were encountered: