Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][cmd/builder] Include replaces in builder versioning tests #10016

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

evan-bradley
Copy link
Contributor

Description

This is necessary when testing the builder with unreleased versions of Collector modules.

Link to tracking issue

Fixes #10014

This is necessary when testing the builder with unreleased versions of Collector modules.
@evan-bradley evan-bradley requested review from codeboten and a team April 22, 2024 18:08
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.62%. Comparing base (cc9e3dd) to head (ad4baec).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10016   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files         360      360           
  Lines       16681    16681           
=======================================
  Hits        15284    15284           
  Misses       1060     1060           
  Partials      337      337           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evan-bradley
Copy link
Contributor Author

@codeboten CI is green, this should be ready to go.

@codeboten codeboten merged commit b473034 into open-telemetry:main Apr 22, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 22, 2024
andrzej-stencel pushed a commit to andrzej-stencel/opentelemetry-collector that referenced this pull request May 27, 2024
…en-telemetry#10016)

#### Description
This is necessary when testing the builder with unreleased versions of
Collector modules.

#### Link to tracking issue
Fixes open-telemetry#10014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

builder test failure is blocking release
2 participants