[mdatagen] fix generated comp test for extensions and unused imports in templates #10477
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When upgrading beyond
v0.101.0
ofmdatagen
I ran into issues upgrading when runninggolanglint-ci
because of unused imports. Namely, incomponent_tests
thecomponent
was removed from this commit which was not caught by tests (it appears we only test receiver components & not others). The logic that generates tests for extensions, where I caught this error, ends up with agenerated_component_test
that does not usecomponent
in the package at all. I would've thought the contrib repo would've detected this issue since they also usemdatagen
and there are extensions there + golangci-lint. I haven't dug into the why it wasn't caught there yet.Testing
I ran this locally against my own repo where the issue originally showed & ensured the value would be templated out appropriately.