-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[confmap] Store original string in confmap.Conf #10618
[confmap] Store original string in confmap.Conf #10618
Conversation
9d5c9ad
to
fbbfc01
Compare
fbbfc01
to
4f0a7ff
Compare
I still need to think about some edge cases and add more tests, but the overall approach should be clear now and can be reviewed |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10618 +/- ##
==========================================
- Coverage 92.38% 92.35% -0.04%
==========================================
Files 403 403
Lines 18729 18796 +67
==========================================
+ Hits 17303 17359 +56
- Misses 1066 1074 +8
- Partials 360 363 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this approach makes sense to address the issue, there are some lint errors that need addressing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this looks like the right approach to me as it lets users continue to set yaml via env vars but also use exact inline env var values in strings.
@MovieStoreGuy it would really help if you can try this one out and confirm that it fixes your issue in an environment as close as possible to the one where you found it |
Final call for reviews, I want to merge this by Thursday EU morning cc @open-telemetry/collector-approvers |
Description
expandedValue
struct that holds the original string representation if available for values resolved from a provider.expandedValue
in the public API by adding asanitize
step before returning anyGet
s orToStringMap
s.string
type and uses the string representation in that case.Link to tracking issue
Fixes #10605, Fixes #10405, Fixes #10659
Testing
This changes the behavior in some cases, I update the test cases.
Documentation