[batchprocessor] Update metric units #10658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10658 +/- ##
=======================================
Coverage 91.64% 91.64%
=======================================
Files 406 406
Lines 19001 19001
=======================================
Hits 17414 17414
Misses 1227 1227
Partials 360 360 ☔ View full report in Codecov by Sentry. |
mx-psi
reviewed
Jul 18, 2024
I suspect we'll have better guidelines in the near future with open-telemetry/oteps#259, but maybe we can start a doc in this repo until the otep lands? |
|
Opened #10695 to provide guidelines around units |
codeboten
pushed a commit
that referenced
this pull request
Jul 30, 2024
#### Description Update telemetry units to be more clear. Related to #10658, we may be blocked here waiting for official units to use. Note: I've kept [one metric](https://github.com/open-telemetry/opentelemetry-collector/blob/7d5b1ba387e4e171e25bfeea9b70d6fdfbe08fab/cmd/mdatagen/internal/samplereceiver/metadata.yaml#L110) with the unit "1", as it's not meant to be meaningful, just to show a metric that's disabled by default. Since this code is internal and only used for tests, from what I can tell, I don't believe we need a changelog entry. #### Link to tracking issue Fixes #10653
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
codeboten
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1isn't an informative metric unit. I've made a best-guess attempt at updating metric units, feedback is very necessary here, the units are not very clear here. I attempted to match the unit with metric descriptions.Semantic conventions for reference.
Link to tracking issue
Fixes #10652