Support profiles in consumertest #10692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
force-pushed
the
profiles-consumertest
branch
from
fa7ed89
to
74298f6
Compare
This was referenced Jul 22, 2024
dmathieu
force-pushed
the
profiles-consumertest
branch
5 times, most recently
from
9897a4d
to
d85f491
Compare
dmathieu
force-pushed
the
profiles-consumertest
branch
2 times, most recently
from
c0c0869
to
9b5ac8d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10692 +/- ##
==========================================
+ Coverage 92.39% 92.40% +0.01%
==========================================
Files 403 403
Lines 18742 18761 +19
==========================================
+ Hits 17316 17337 +21
+ Misses 1066 1065 -1
+ Partials 360 359 -1 ☔ View full report in Codecov by Sentry. |
dmathieu
force-pushed
the
profiles-consumertest
branch
from
9b5ac8d
to
ee12cd3
Compare
dmathieu
force-pushed
the
profiles-consumertest
branch
from
ee12cd3
to
db23874
Compare
|
This package being test utils, it didn't seem like it warrants a new |
djaglowski
approved these changes
Jul 22, 2024
dmathieu
force-pushed
the
profiles-consumertest
branch
from
b00b72c
to
ba5415d
Compare
|
Following a chat with @mx-psi, I have turned |
dmathieu
force-pushed
the
profiles-consumertest
branch
from
9ce3dcb
to
d2c3e15
Compare
dmathieu
force-pushed
the
profiles-consumertest
branch
from
d2c3e15
to
5e280b9
Compare
djaglowski
approved these changes
Jul 22, 2024
mx-psi
approved these changes
Jul 23, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following #10464, this adds profiles support in consumertest.
cc @mx-psi