[service] Remove servicetelemetry.TelemetrySettings #10728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
force-pushed
the
service-remove-servicetelemetry
branch
from
dae58da
to
5aaad3c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10728 +/- ##
=======================================
Coverage 92.18% 92.18%
=======================================
Files 403 401 -2
Lines 18792 18786 -6
=======================================
- Hits 17323 17318 -5
+ Misses 1109 1108 -1
Partials 360 360 ☔ View full report in Codecov by Sentry. |
mx-psi
approved these changes
Jul 26, 2024
| # Use this changelog template to create an entry for release notes. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: breaking |
There was a problem hiding this comment.
I have not been able to find any public references to this symbol being used as an argument to a function, so I think it's okay to do in one go
atoulme
approved these changes
Jul 26, 2024
mwear
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reorganizes service to not require
servicetelemetry.TelemetrySettingsand instead depend directly oncomponent.TelemetrySettingsWhether or not we move forward with #10725 I think this is a useful change for service.
Testing
Unit tests