Move extension builder into internal service #10785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10785 +/- ##
==========================================
+ Coverage 91.67% 91.68% +0.01%
==========================================
Files 408 409 +1
Lines 19164 19192 +28
==========================================
+ Hits 17568 17596 +28
Misses 1237 1237
Partials 359 359 ☔ View full report in Codecov by Sentry. |
|
Before we break the API, we typically deprecate it for at least one release. More here: https://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.md#breaking-changes |
dmathieu
force-pushed
the
move-extension-builder
branch
from
9931052
to
4da3110
Compare
dmathieu
force-pushed
the
move-extension-builder
branch
from
57a3485
to
e381ee9
Compare
mx-psi
approved these changes
Aug 22, 2024
mx-psi
pushed a commit
that referenced
this pull request
Aug 30, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description There builders were deprecated in 0.108.0, so they can be removed now. PRs that deprecated the builders: * #10781 * #10782 * #10783 * #10784 * #10785 cc @mx-psi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves the connector builder out of the
connectorpackage, and intoservice/internal/builders.There's no real reason for this struct to be public (folks shouldn't call it), and making it private will allow us to add profiling support to it.
Link to tracking issue
#10375 (review)
While this is not technically required for the profiles work (there is no notion of signals in extensions), this PR is here to keep things consistent.