Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[confmap] Validate providers scheme when building a Resolver #10786

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Aug 1, 2024

Description

Validate providers schemes when building a Resolver.

I don't consider this a breaking change since the providers would be useless if they don't follow this pattern.

@mx-psi mx-psi force-pushed the mx-psi/restrict-providers-scheme branch from 5e427e3 to 69c72cd Compare August 1, 2024 16:44
@mx-psi mx-psi marked this pull request as ready for review August 1, 2024 16:44
@mx-psi mx-psi requested review from a team and songy23 August 1, 2024 16:44
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.70%. Comparing base (2bb2613) to head (dddc22f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10786      +/-   ##
==========================================
- Coverage   91.71%   91.70%   -0.01%     
==========================================
  Files         406      406              
  Lines       18947    18952       +5     
==========================================
+ Hits        17377    17380       +3     
- Misses       1211     1212       +1     
- Partials      359      360       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

confmap/resolver.go Show resolved Hide resolved
@mx-psi mx-psi merged commit 2beed98 into open-telemetry:main Aug 2, 2024
50 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants