Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[consumer] Add tracing to all the components #10847

Open
wants to merge 36 commits into
base: main
Choose a base branch
from

Conversation

iblancasa
Copy link
Contributor

Description

Add tracing to all the components

Link to tracking issue

Fixes #8804

Testing

Based on #8833

@iblancasa iblancasa requested review from a team and codeboten August 9, 2024 15:46
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.86%. Comparing base (30b4ed0) to head (0c5c512).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10847   +/-   ##
=======================================
  Coverage   91.85%   91.86%           
=======================================
  Files         415      416    +1     
  Lines       19850    19878   +28     
=======================================
+ Hits        18234    18260   +26     
- Misses       1244     1245    +1     
- Partials      372      373    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iblancasa iblancasa marked this pull request as draft August 9, 2024 16:03
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@iblancasa iblancasa marked this pull request as ready for review August 9, 2024 16:51
@iblancasa
Copy link
Contributor Author

Hi @codeboten can you take a look to this PR?

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has the same downsides of the original PR which is that it exposes additional interface for the consumer package. I suggested #8910 as an alternative implementation but there were some challenges with that one as well.

Pinging @dmitryax and @bogdandrutu as they reviewed the original PRs

@iblancasa
Copy link
Contributor Author

This has the same downsides of the original PR which is that it exposes additional interface for the consumer package. I suggested #8910 as an alternative implementation but there were some challenges with that one as well.

Pinging @dmitryax and @bogdandrutu as they reviewed the original PRs

Sorry. Didn't see that one.

I would happily retake the other approach if preferred or research any possible improvements.

@iblancasa iblancasa requested a review from a team as a code owner September 19, 2024 11:07
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be outside the scope of this PR but it would be nice if, as we are adding telemetry to components, we could make sure we're using the attributes described on #11179.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tracing information to all components
3 participants