-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[confmap] Use stringy representation on stringy types #10938
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10938 +/- ##
==========================================
- Coverage 91.89% 91.88% -0.01%
==========================================
Files 411 411
Lines 19311 19327 +16
==========================================
+ Hits 17745 17759 +14
- Misses 1217 1218 +1
- Partials 349 350 +1 ☔ View full report in Codecov by Sentry. |
d79c469
to
2861abc
Compare
2861abc
to
097f58b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @mx-psi. Just on question
Description
Use string value for stringy types
Link to tracking issue
Fixes #10937
Testing
Adds tests for stringy type recognition and adds end to end tests