Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[configgrpc] fix integer overflow in grpc server configuration #10948

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

codeboten
Copy link
Contributor

Change the value of max_recv_msg_size_mib from uint64 to int to avoid a case where misconfiguration caused an integer overflow. Added a Validate function to configgrpc as part of this to validate that users didn't set the value to something that would overflow when converted from megabytes to bytes.

Change the value of max_recv_msg_size_mib from uint64 to int to avoid a case where misconfiguration caused an integer overflow. Added a Validate function to configgrpc as part of this to validate that users didn't set the value to something that would overflow when converted from megabytes to bytes.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten requested review from a team and bogdandrutu August 22, 2024 18:45
@codeboten
Copy link
Contributor Author

@codeboten codeboten changed the title [configgrpc] fix integer overflow in configuration [configgrpc] fix integer overflow in grpc server configuration Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.88%. Comparing base (b10029c) to head (1334e0f).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
config/configgrpc/configgrpc.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10948      +/-   ##
==========================================
- Coverage   91.89%   91.88%   -0.01%     
==========================================
  Files         411      411              
  Lines       19311    19319       +8     
==========================================
+ Hits        17745    17752       +7     
- Misses       1217     1218       +1     
  Partials      349      349              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten merged commit 6329c24 into open-telemetry:main Aug 29, 2024
47 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 29, 2024
@codeboten codeboten deleted the codeboten/int64-int branch August 29, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants