Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdatagen] fix a missing import in a generated test file #10970

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

codeboten
Copy link
Contributor

Fixes #10969

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten requested review from a team and songy23 August 27, 2024 01:02
@codeboten
Copy link
Contributor Author

Manually tested this in contrib as well to confirm it addresses the issue.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.86%. Comparing base (9e1af01) to head (c68dffc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10970      +/-   ##
==========================================
- Coverage   91.87%   91.86%   -0.02%     
==========================================
  Files         411      411              
  Lines       19328    19328              
==========================================
- Hits        17758    17756       -2     
- Misses       1220     1221       +1     
- Partials      350      351       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten merged commit 5963d44 into open-telemetry:main Aug 27, 2024
49 checks passed
@codeboten codeboten deleted the codeboten/fix-10969 branch August 27, 2024 01:22
@github-actions github-actions bot added this to the next release milestone Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mdatagen: generates code that's missing a dependency
2 participants