Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profiles support in service #11024

Merged
merged 11 commits into from
Sep 5, 2024
Merged

Conversation

dmathieu
Copy link
Member

Description

This is the last PR to add profiles support, adding it to the service package.

This is based after #11023.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 90.78947% with 14 lines in your changes missing coverage. Please review.

Project coverage is 92.22%. Comparing base (46d0f73) to head (08cfd9c).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
service/internal/graph/nodes.go 74.07% 7 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11024      +/-   ##
==========================================
- Coverage   92.23%   92.22%   -0.02%     
==========================================
  Files         406      406              
  Lines       19101    19252     +151     
==========================================
+ Hits        17618    17755     +137     
- Misses       1123     1130       +7     
- Partials      360      367       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi
Copy link
Member

mx-psi commented Sep 3, 2024

I think this can be marked as ready for review now!

@dmathieu dmathieu marked this pull request as ready for review September 3, 2024 09:15
@dmathieu dmathieu requested review from a team and mx-psi September 3, 2024 09:15
@mx-psi mx-psi merged commit 720f3a8 into open-telemetry:main Sep 5, 2024
48 of 49 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 5, 2024
@dmathieu dmathieu deleted the profiles-service branch September 6, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants