Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[processorhelper] deprecating unused methods" #11114

Closed

Conversation

djaglowski
Copy link
Member

Reverts #11083

I'd like to propose that these metrics not be deprecated unless Accepted, Refused, and Dropped are also deprecated. These four metrics describe a complete picture of telemetry flowing through processors.

Personally I'd like to deprecate all four in favor of #10708 because the latter can be captured automatically.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.23%. Comparing base (3ed205e) to head (3b01a04).
Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11114   +/-   ##
=======================================
  Coverage   92.23%   92.23%           
=======================================
  Files         414      414           
  Lines       19810    19810           
=======================================
  Hits        18271    18271           
  Misses       1167     1167           
  Partials      372      372           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djaglowski
Copy link
Member Author

After discussing with @codeboten and @mx-psi, we agreed that the associated "accepted", "refused", and "dropped" metrics will also be deprecated.

@djaglowski djaglowski closed this Sep 11, 2024
@djaglowski djaglowski deleted the revert-11083-codeboten/deprecate-unused-methods branch September 11, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant