Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add version code to cmd/builder #11208

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jackgopack4
Copy link
Contributor

@jackgopack4 jackgopack4 commented Sep 18, 2024

Revert "[chore] delete code to set a version and date, as it it not used (#10715)"
Remove date string but re-add functions that check for version number
This (mostly) reverts commit b53f57d.

Description

This re-enables the functionality to set a version number for ocb binary (cmd/builder). It was erroneously removed. It also adds unit tests for this functionality, as a warning is given on CI with no code coverage.

Link to tracking issue

Relates to open-telemetry/opentelemetry-collector-releases#664.
Closes #11220 along with open-telemetry/opentelemetry-collector-releases#665

Testing

ran build and release cycles inside personal fork repositories (jackgopack4/opentelemetry-collector and jackgopack4/opentelemetry-collector-releases)

Documentation

.chloggen file

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.82%. Comparing base (07c3e17) to head (efc72fa).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11208      +/-   ##
==========================================
+ Coverage   91.79%   91.82%   +0.03%     
==========================================
  Files         424      424              
  Lines       20094    20101       +7     
==========================================
+ Hits        18445    18458      +13     
+ Misses       1269     1265       -4     
+ Partials      380      378       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jackgopack4 jackgopack4 reopened this Sep 19, 2024
@jackgopack4 jackgopack4 marked this pull request as ready for review September 19, 2024 18:09
@jackgopack4 jackgopack4 requested a review from a team as a code owner September 19, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCB v0.107.0 and onward no longer report version on command line
2 participants