[configgrpc] Replace deprecated ToClientConn and ToServer with new API #11271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11271 +/- ##
==========================================
- Coverage 91.42% 91.41% -0.01%
==========================================
Files 424 424
Lines 20188 20182 -6
==========================================
- Hits 18456 18450 -6
- Misses 1348 1350 +2
+ Partials 384 382 -2 ☔ View full report in Codecov by Sentry. |
bogdandrutu
approved these changes
Sep 25, 2024
bogdandrutu
approved these changes
Sep 27, 2024
jackgopack4
pushed a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Oct 8, 2024
open-telemetry#11271) #### Description `ClientConfig.ToClientConn` and `ServerConfig.ToServer` were deprecated in v0.110.0 in favor of `ClientConfig.ToClientConnWithOptions` and `ServerConfig.ToServerWithOptions` which use a more flexible option type (open-telemetry#11069). The original functions are now removed, and the new ones are renamed to the old names. The `WithOptions` names are kept as deprecated aliases for now. Note: The "4 lines missing coverage" are from the `WithOptions` function aliases. #### Link to tracking issue Updates open-telemetry#9480 #### Next steps - `collector-contrib` will need to be updated to rename uses of the `WithOptions` functions - The newly deprecated aliases will then need to be removed in the next release
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ClientConfig.ToClientConnandServerConfig.ToServerwere deprecated in v0.110.0 in favor ofClientConfig.ToClientConnWithOptionsandServerConfig.ToServerWithOptionswhich use a more flexible option type (#11069). The original functions are now removed, and the new ones are renamed to the old names. TheWithOptionsnames are kept as deprecated aliases for now.Note: The "4 lines missing coverage" are from the
WithOptionsfunction aliases.Link to tracking issue
Updates #9480
Next steps
collector-contribwill need to be updated to rename uses of theWithOptionsfunctions