Unmarshal span and link flags from JSON #11275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
force-pushed
the
json-decoded-flag
branch
from
af3f97f
to
572d8d5
Compare
For both the `Span` and `SpanLink`, the current unmarshalJsoniter methods do not unmarshal the `flags` field. This updates the functionality to correctly decode these values into the destination. Fix open-telemetry#11267 Signed-off-by: Tyler Yahn <codingalias@gmail.com>
MrAlias
force-pushed
the
json-decoded-flag
branch
from
572d8d5
to
45b366a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11275 +/- ##
=======================================
Coverage 91.44% 91.44%
=======================================
Files 424 424
Lines 20182 20186 +4
=======================================
+ Hits 18456 18460 +4
Misses 1342 1342
Partials 384 384 ☔ View full report in Codecov by Sentry. |
bogdandrutu
approved these changes
Sep 25, 2024
codeboten
approved these changes
Sep 25, 2024
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
jackgopack4
pushed a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Oct 8, 2024
For both the `Span` and `SpanLink`, the current unmarshalJsoniter methods do not unmarshal the `flags` field. This updates the functionality to correctly decode these values into the destination. Fix open-telemetry#11267 Signed-off-by: Tyler Yahn <codingalias@gmail.com> --------- Signed-off-by: Tyler Yahn <codingalias@gmail.com> Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com> Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
jackgopack4
pushed a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Oct 8, 2024
…r int (open-telemetry#11279) Bug added in open-telemetry#11275 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For both the
SpanandSpanLink, the current unmarshalJsoniter methods do not unmarshal theflagsfield. This updates the functionality to correctly decode these values into the destination.Fix #11267
Signed-off-by: Tyler Yahn codingalias@gmail.com