[exporter] Disable the API to pass in configurations using a callback that operates on batch sender #11448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-sili
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11448 +/- ##
==========================================
- Coverage 92.15% 92.15% -0.01%
==========================================
Files 432 431 -1
Lines 20253 20238 -15
==========================================
- Hits 18664 18650 -14
+ Misses 1228 1227 -1
Partials 361 361 ☔ View full report in Codecov by Sentry. |
|
Please add a |
dmitryax
reviewed
Oct 15, 2024
bogdandrutu
reviewed
Oct 15, 2024
bogdandrutu
approved these changes
Oct 15, 2024
bogdandrutu
reviewed
Oct 15, 2024
| @@ -275,30 +275,14 @@ func WithCapabilities(capabilities consumer.Capabilities) Option { | |||
| } | |||
| } | |||
|
|
|||
| // WithRequestBatchFuncs sets the functions for merging and splitting batches for an exporter built for custom request types. | |||
| func WithRequestBatchFuncs(mf exporterbatcher.BatchMergeFunc[internal.Request], msf exporterbatcher.BatchMergeSplitFunc[internal.Request]) BatcherOption { | |||
dmitryax
reviewed
Oct 15, 2024
dmitryax
approved these changes
Oct 16, 2024
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector
that referenced
this pull request
Nov 21, 2024
… that operates on batch sender (open-telemetry#11448) #### Description As part of the effort to solve open-telemetry#10368, we no longer guarantee to initialize a `batchSender` when `batcher` is enabled. Therefore, we would like to remove the interface to set `mergeFunc` and `mergeSplitFunc` as a callback that operates on `batchSender`. Instead, users should use the alternative `WithBatchFuncs` that is a callback that operates `baseExporter`. Context: open-telemetry#11414 #### Link to tracking issue open-telemetry#8122 open-telemetry#10368 --------- Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
… that operates on batch sender (open-telemetry#11448) #### Description As part of the effort to solve open-telemetry#10368, we no longer guarantee to initialize a `batchSender` when `batcher` is enabled. Therefore, we would like to remove the interface to set `mergeFunc` and `mergeSplitFunc` as a callback that operates on `batchSender`. Instead, users should use the alternative `WithBatchFuncs` that is a callback that operates `baseExporter`. Context: open-telemetry#11414 #### Link to tracking issue open-telemetry#8122 open-telemetry#10368 --------- Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of the effort to solve #10368, we no longer guarantee to initialize a
batchSenderwhenbatcheris enabled. Therefore, we would like to remove the interface to setmergeFuncandmergeSplitFuncas a callback that operates onbatchSender. Instead, users should use the alternativeWithBatchFuncsthat is a callback that operatesbaseExporter.Context: #11414
Link to tracking issue
#8122
#10368
Testing
Documentation