-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Split mdatagen configs in different files #11519
[chore] Split mdatagen configs in different files #11519
Conversation
56003ef
to
2b592c6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11519 +/- ##
==========================================
- Coverage 91.38% 91.36% -0.02%
==========================================
Files 433 434 +1
Lines 23659 23659
==========================================
- Hits 21620 21616 -4
- Misses 1663 1666 +3
- Partials 376 377 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2b592c6
to
bb6316e
Compare
if md.Status != nil { | ||
// status is not required for subcomponents. | ||
errs = errors.Join(errs, errors.New("status must be empty for subcomponents")) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this error condition was not present on the original file, and it is making the contrib release fail. Part of the solution is #11167, but could we also have these kinds of changes listed in the PR description (and maybe changelog as well)? It was a bit hard for me to debug this (since the PR title talks about just moving files around, I discarded this PR as the cause of the error initially)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vote to reset back to the original logic, and have an issue if we want to evolve the logic.
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
No description provided.