Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Add issue template for RFC votes #11559

Merged
merged 6 commits into from
Nov 4, 2024

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Oct 29, 2024

Description

Adds issue template for making votes.

Link to tracking issue

Fixes #11552

@mx-psi mx-psi requested a review from a team as a code owner October 29, 2024 13:14
@mx-psi mx-psi requested a review from evan-bradley October 29, 2024 13:15
@mx-psi mx-psi added Skip Changelog PRs that do not require a CHANGELOG.md entry Skip Contrib Tests labels Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.46%. Comparing base (002a748) to head (f2e3581).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11559   +/-   ##
=======================================
  Coverage   91.45%   91.46%           
=======================================
  Files         440      440           
  Lines       23887    23887           
=======================================
+ Hits        21846    21848    +2     
+ Misses       1661     1660    -1     
+ Partials      380      379    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/ISSUE_TEMPLATE/vote.md Outdated Show resolved Hide resolved
@mx-psi
Copy link
Member Author

mx-psi commented Oct 30, 2024

@open-telemetry/collector-approvers I will merge this on Monday. This is just a way to make the RFC decision process easier to follow with a template, so I don't think there would be anything controversial.

Note that after discussing with Dan I added the following clarification:

For any stakeholder team, we consider the people that were part of the team at the time the vote is called

.github/ISSUE_TEMPLATE/vote.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/vote.md Outdated Show resolved Hide resolved
mx-psi and others added 2 commits October 30, 2024 17:42
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
@mx-psi mx-psi merged commit 0982ff8 into open-telemetry:main Nov 4, 2024
33 of 34 checks passed
@mx-psi mx-psi deleted the mx-psi/vote-issue-template branch November 4, 2024 11:02
@github-actions github-actions bot added this to the next release milestone Nov 4, 2024
djaglowski pushed a commit to djaglowski/opentelemetry-collector that referenced this pull request Nov 21, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number if applicable -->

Adds issue template for making votes.

#### Link to tracking issue
Fixes open-telemetry#11552

---------

Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number if applicable -->

Adds issue template for making votes.

#### Link to tracking issue
Fixes open-telemetry#11552

---------

Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry Skip Contrib Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add issue template for voting
5 participants