-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] [exporterqueue] Add splitting to the experimental pull-based batcher #11580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11580 +/- ##
==========================================
- Coverage 91.53% 91.52% -0.02%
==========================================
Files 441 441
Lines 23848 23914 +66
==========================================
+ Hits 21830 21888 +58
- Misses 1645 1650 +5
- Partials 373 376 +3 ☔ View full report in Codecov by Sentry. |
sfc-gh-sili
changed the title
batcher not supporting split as well
batcher now supporting split as well
Oct 31, 2024
sfc-gh-sili
changed the title
batcher now supporting split as well
[exporterqueue] Default Batcher now supports splitting
Oct 31, 2024
dmitryax
changed the title
[exporterqueue] Default Batcher now supports splitting
[chore] [exporterqueue] Add splitting to the experimental pull-based batcher
Nov 3, 2024
dmitryax
reviewed
Nov 3, 2024
dmitryax
reviewed
Nov 3, 2024
Minor comment. Otherwise, LGTM! |
sfc-gh-sili
force-pushed
the
sili-queue-tiny-4
branch
from
November 6, 2024 00:35
9025bba
to
f3182ba
Compare
dmitryax
approved these changes
Nov 6, 2024
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector
that referenced
this pull request
Nov 21, 2024
…batcher (open-telemetry#11580) #### Description This PR follows open-telemetry#11546 and add support for splitting (i.e. support setting a maximum request size) Design doc: https://docs.google.com/document/d/1y5jt7bQ6HWt04MntF8CjUwMBBeNiJs2gV4uUZfJjAsE/edit?usp=sharing #### Link to tracking issue open-telemetry#8122 open-telemetry#10368
This was referenced Dec 11, 2024
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
…batcher (open-telemetry#11580) #### Description This PR follows open-telemetry#11546 and add support for splitting (i.e. support setting a maximum request size) Design doc: https://docs.google.com/document/d/1y5jt7bQ6HWt04MntF8CjUwMBBeNiJs2gV4uUZfJjAsE/edit?usp=sharing #### Link to tracking issue open-telemetry#8122 open-telemetry#10368
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR follows #11546 and add support for splitting (i.e. support setting a maximum request size)
Design doc:
https://docs.google.com/document/d/1y5jt7bQ6HWt04MntF8CjUwMBBeNiJs2gV4uUZfJjAsE/edit?usp=sharing
Link to tracking issue
#8122
#10368
Documentation