Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] [exporterqueue] Add splitting to the experimental pull-based batcher #11580

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

sfc-gh-sili
Copy link
Contributor

@sfc-gh-sili sfc-gh-sili commented Oct 31, 2024

Description

This PR follows #11546 and add support for splitting (i.e. support setting a maximum request size)

Design doc:
https://docs.google.com/document/d/1y5jt7bQ6HWt04MntF8CjUwMBBeNiJs2gV4uUZfJjAsE/edit?usp=sharing

Link to tracking issue

#8122
#10368

Documentation

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 10 lines in your changes missing coverage. Please review.

Project coverage is 91.52%. Comparing base (e053173) to head (f3182ba).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
exporter/internal/queue/fake_request.go 73.68% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11580      +/-   ##
==========================================
- Coverage   91.53%   91.52%   -0.02%     
==========================================
  Files         441      441              
  Lines       23848    23914      +66     
==========================================
+ Hits        21830    21888      +58     
- Misses       1645     1650       +5     
- Partials      373      376       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-sili sfc-gh-sili changed the title batcher not supporting split as well batcher now supporting split as well Oct 31, 2024
@sfc-gh-sili sfc-gh-sili changed the title batcher now supporting split as well [exporterqueue] Default Batcher now supports splitting Oct 31, 2024
@sfc-gh-sili sfc-gh-sili marked this pull request as ready for review October 31, 2024 07:24
@sfc-gh-sili sfc-gh-sili requested a review from a team as a code owner October 31, 2024 07:24
@sfc-gh-sili sfc-gh-sili requested a review from songy23 October 31, 2024 07:24
@songy23 songy23 requested a review from dmitryax October 31, 2024 14:09
@dmitryax dmitryax changed the title [exporterqueue] Default Batcher now supports splitting [chore] [exporterqueue] Add splitting to the experimental pull-based batcher Nov 3, 2024
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 3, 2024
@dmitryax
Copy link
Member

dmitryax commented Nov 3, 2024

Minor comment. Otherwise, LGTM!

@sfc-gh-sili sfc-gh-sili requested a review from dmitryax November 4, 2024 18:02
@dmitryax dmitryax merged commit e76145a into open-telemetry:main Nov 6, 2024
48 of 49 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 6, 2024
@sfc-gh-sili sfc-gh-sili deleted the sili-queue-tiny-4 branch November 12, 2024 23:20
djaglowski pushed a commit to djaglowski/opentelemetry-collector that referenced this pull request Nov 21, 2024
…batcher (open-telemetry#11580)

#### Description

This PR follows
open-telemetry#11546 and
add support for splitting (i.e. support setting a maximum request size)

Design doc:

https://docs.google.com/document/d/1y5jt7bQ6HWt04MntF8CjUwMBBeNiJs2gV4uUZfJjAsE/edit?usp=sharing

#### Link to tracking issue

open-telemetry#8122
open-telemetry#10368
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
…batcher (open-telemetry#11580)

#### Description

This PR follows
open-telemetry#11546 and
add support for splitting (i.e. support setting a maximum request size)

Design doc:

https://docs.google.com/document/d/1y5jt7bQ6HWt04MntF8CjUwMBBeNiJs2gV4uUZfJjAsE/edit?usp=sharing

#### Link to tracking issue

open-telemetry#8122
open-telemetry#10368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants