Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] add retry logic to flaky http test #11655

Merged

Conversation

jackgopack4
Copy link
Contributor

Description

attempts to fix flaky service/telemetry/metrics test

Link to tracking issue

Fixes #11654

Testing

update to test helper function

Documentation

n/a

@jackgopack4 jackgopack4 changed the title add retry logic to flaky http test [chore] add retry logic to flaky http test Nov 12, 2024
@jackgopack4 jackgopack4 marked this pull request as ready for review November 12, 2024 19:17
@jackgopack4 jackgopack4 requested a review from a team as a code owner November 12, 2024 19:17
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.59%. Comparing base (7b31c96) to head (7aca683).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11655   +/-   ##
=======================================
  Coverage   91.58%   91.59%           
=======================================
  Files         440      440           
  Lines       23768    23755   -13     
=======================================
- Hits        21769    21759   -10     
+ Misses       1627     1625    -2     
+ Partials      372      371    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

service/telemetry/metrics_test.go Outdated Show resolved Hide resolved
service/telemetry/metrics_test.go Show resolved Hide resolved
service/telemetry/metrics_test.go Show resolved Hide resolved
@jackgopack4
Copy link
Contributor Author

thanks for the suggestions, applied them

@bogdandrutu bogdandrutu merged commit 75a77b7 into open-telemetry:main Nov 13, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestTelemetryInit failing sporadically in GH Actions pipeline
2 participants