Add a new scraper package to replace scraperhelper #11657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
added
the
Skip Changelog
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11657 +/- ##
==========================================
+ Coverage 91.58% 91.60% +0.01%
==========================================
Files 440 443 +3
Lines 23768 23818 +50
==========================================
+ Hits 21769 21818 +49
- Misses 1627 1628 +1
Partials 372 372 ☔ View full report in Codecov by Sentry. |
bogdandrutu
force-pushed
the
new-scraper
branch
3 times, most recently
from
8d188b2 to
96623b0
Compare
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
new-scraper
branch
from
96623b0 to
7f55318
Compare
bogdandrutu
added a commit
that referenced
this pull request
Nov 13, 2024
Changes interface to get closer to #11657 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
songy23
reviewed
Nov 13, 2024
| status: | ||
| class: pkg | ||
| stability: | ||
| development: [metrics] |
There was a problem hiding this comment.
Are traces & logs in scope too?
There was a problem hiding this comment.
I think we will extend to logs at one point, see request #11238 (comment).
For me the first part is to move what we have (only metrics) to this new framework proposed in the issue, then we can extend to logs.
songy23
approved these changes
Nov 13, 2024
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector
that referenced
this pull request
Nov 21, 2024
…metry#11659) Changes interface to get closer to open-telemetry#11657 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector
that referenced
this pull request
Nov 21, 2024
) Update open-telemetry#11238 No changelog since this is still in progress. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
|
@bogdandrutu May I ask what would be the next step of this PR? Are we planning to remove scraperhelper/scrapercontroller as well? |
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
…metry#11659) Changes interface to get closer to open-telemetry#11657 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
) Update open-telemetry#11238 No changelog since this is still in progress. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update #11238
No changelog since this is still in progress.