-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Run make genotelcorecol
to fix "build-and-test / checks"
#11676
[chore] Run make genotelcorecol
to fix "build-and-test / checks"
#11676
Conversation
make genotelcorecol
to fix "build-and-test / checks"make genotelcorecol
to fix "build-and-test / checks"
You need to update https://github.com/open-telemetry/opentelemetry-collector/blob/main/.github/workflows/build-and-test.yml#L48 (and everywhere) |
Interesting, at the moment it seems some runs of |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11676 +/- ##
==========================================
+ Coverage 91.62% 91.64% +0.01%
==========================================
Files 439 442 +3
Lines 23682 23746 +64
==========================================
+ Hits 21698 21761 +63
- Misses 1615 1616 +1
Partials 369 369 ☔ View full report in Codecov by Sentry. |
Can you clarify ? |
The failing run I linked earlier specified version ~1.22.8, which resolved to 1.22.9, causing a conflict with the But the first run in this PR also failed, because the same specification resolved to 1.22.8, causing a conflict with the updated I just updated the CI to use ~1.22.9, so for the time being it should be unambiguous, but I think that's an additional reason to want to switch to exact minor versions. |
…pen-telemetry#11676) #### Description The "build-and-test / checks" CI job specifies `go-version: ~1.22.8`. Today, this started resolving to `1.22.9`, causing [errors in CI](https://github.com/open-telemetry/opentelemetry-collector/actions/runs/11839445874/job/32990922879?pr=11670) because of the `toolchain 1.22.8` directive in `otelcorecol/go.mod`. This PR just updates the directive to fix the error. A more long-term solution may be preferred, such as using exact versions instead of `~` versions in CI.
…pen-telemetry#11676) #### Description The "build-and-test / checks" CI job specifies `go-version: ~1.22.8`. Today, this started resolving to `1.22.9`, causing [errors in CI](https://github.com/open-telemetry/opentelemetry-collector/actions/runs/11839445874/job/32990922879?pr=11670) because of the `toolchain 1.22.8` directive in `otelcorecol/go.mod`. This PR just updates the directive to fix the error. A more long-term solution may be preferred, such as using exact versions instead of `~` versions in CI.
Description
The "build-and-test / checks" CI job specifies
go-version: ~1.22.8
. Today, this started resolving to1.22.9
, causing errors in CI because of thetoolchain 1.22.8
directive inotelcorecol/go.mod
. This PR just updates the directive to fix the error. A more long-term solution may be preferred, such as using exact versions instead of~
versions in CI.