Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Run make genotelcorecol to fix "build-and-test / checks" #11676

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

jade-guiton-dd
Copy link
Contributor

@jade-guiton-dd jade-guiton-dd commented Nov 14, 2024

Description

The "build-and-test / checks" CI job specifies go-version: ~1.22.8. Today, this started resolving to 1.22.9, causing errors in CI because of the toolchain 1.22.8 directive in otelcorecol/go.mod. This PR just updates the directive to fix the error. A more long-term solution may be preferred, such as using exact versions instead of ~ versions in CI.

@jade-guiton-dd jade-guiton-dd requested a review from a team as a code owner November 14, 2024 16:21
@jade-guiton-dd jade-guiton-dd changed the title Run make genotelcorecol to fix "build-and-test / checks" [chore] Run make genotelcorecol to fix "build-and-test / checks" Nov 14, 2024
@bogdandrutu bogdandrutu added Skip Changelog PRs that do not require a CHANGELOG.md entry Skip Contrib Tests labels Nov 14, 2024
@bogdandrutu
Copy link
Member

You need to update https://github.com/open-telemetry/opentelemetry-collector/blob/main/.github/workflows/build-and-test.yml#L48 (and everywhere)

@jade-guiton-dd
Copy link
Contributor Author

jade-guiton-dd commented Nov 14, 2024

Interesting, at the moment it seems some runs of check resolve ~1.22.8 to 1.22.8, and others to 1.22.9...

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.64%. Comparing base (eaeacaf) to head (c7c7146).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11676      +/-   ##
==========================================
+ Coverage   91.62%   91.64%   +0.01%     
==========================================
  Files         439      442       +3     
  Lines       23682    23746      +64     
==========================================
+ Hits        21698    21761      +63     
- Misses       1615     1616       +1     
  Partials      369      369              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu
Copy link
Member

Interesting, at the moment it seems some runs of check resolve ~1.22.8 to 1.22.8, and others to 1.22.9...

Can you clarify ?

@jade-guiton-dd
Copy link
Contributor Author

jade-guiton-dd commented Nov 14, 2024

Can you clarify ?

The failing run I linked earlier specified version ~1.22.8, which resolved to 1.22.9, causing a conflict with the toolchain 1.22.8 directive.

But the first run in this PR also failed, because the same specification resolved to 1.22.8, causing a conflict with the updated toolchain 1.22.9 directive. I suspect some kind of cache effect causing different runs to find different "latest" versions.

I just updated the CI to use ~1.22.9, so for the time being it should be unambiguous, but I think that's an additional reason to want to switch to exact minor versions.

@bogdandrutu bogdandrutu merged commit a26bc46 into open-telemetry:main Nov 14, 2024
36 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 14, 2024
djaglowski pushed a commit to djaglowski/opentelemetry-collector that referenced this pull request Nov 21, 2024
…pen-telemetry#11676)

#### Description

The "build-and-test / checks" CI job specifies `go-version: ~1.22.8`.
Today, this started resolving to `1.22.9`, causing [errors in
CI](https://github.com/open-telemetry/opentelemetry-collector/actions/runs/11839445874/job/32990922879?pr=11670)
because of the `toolchain 1.22.8` directive in `otelcorecol/go.mod`.
This PR just updates the directive to fix the error. A more long-term
solution may be preferred, such as using exact versions instead of `~`
versions in CI.
@jade-guiton-dd jade-guiton-dd deleted the bump-go-1.22.9 branch November 27, 2024 13:37
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
…pen-telemetry#11676)

#### Description

The "build-and-test / checks" CI job specifies `go-version: ~1.22.8`.
Today, this started resolving to `1.22.9`, causing [errors in
CI](https://github.com/open-telemetry/opentelemetry-collector/actions/runs/11839445874/job/32990922879?pr=11670)
because of the `toolchain 1.22.8` directive in `otelcorecol/go.mod`.
This PR just updates the directive to fix the error. A more long-term
solution may be preferred, such as using exact versions instead of `~`
versions in CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry Skip Contrib Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants