Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter] Feature gate for queue batcher #11721

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

sfc-gh-sili
Copy link
Contributor

Description

This PR proceeds #11637. It

  • Introduces a noop feature gate that will be used for queue batcher.
  • Updates exporter tests to run with both the feature gate on and off.

Link to tracking issue

#10368
#8122

Testing

Documentation

@sfc-gh-sili sfc-gh-sili requested a review from a team as a code owner November 21, 2024 08:53
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.63%. Comparing base (085db59) to head (47f7b1a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11721   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files         442      443    +1     
  Lines       23776    23782    +6     
=======================================
+ Hits        21787    21793    +6     
  Misses       1618     1618           
  Partials      371      371           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@songy23 songy23 requested a review from dmitryax November 21, 2024 17:13
@sfc-gh-sili sfc-gh-sili force-pushed the sili-feature-gate-only branch from 3c3e38b to cec7692 Compare November 21, 2024 21:06
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 21, 2024
@dmitryax
Copy link
Member

@sfc-gh-sili please run make crosslink

@dmitryax
Copy link
Member

Now make gotidy is needed :)

@songy23 songy23 added the ready-to-merge Code review completed; ready to merge by maintainers label Nov 22, 2024
@bogdandrutu bogdandrutu merged commit 827888d into open-telemetry:main Nov 22, 2024
66 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 22, 2024
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This PR proceeds
open-telemetry#11637. It
* Introduces a noop feature gate that will be used for queue batcher.
* Updates exporter tests to run with both the feature gate on and off.

<!-- Issue number if applicable -->
#### Link to tracking issue
open-telemetry#10368
open-telemetry#8122


<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants