-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter] Feature gate for queue batcher #11721
Merged
bogdandrutu
merged 4 commits into
open-telemetry:main
from
sfc-gh-sili:sili-feature-gate-only
Nov 22, 2024
Merged
[exporter] Feature gate for queue batcher #11721
bogdandrutu
merged 4 commits into
open-telemetry:main
from
sfc-gh-sili:sili-feature-gate-only
Nov 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11721 +/- ##
=======================================
Coverage 91.63% 91.63%
=======================================
Files 442 443 +1
Lines 23776 23782 +6
=======================================
+ Hits 21787 21793 +6
Misses 1618 1618
Partials 371 371 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
sfc-gh-sili
force-pushed
the
sili-feature-gate-only
branch
from
November 21, 2024 21:06
3c3e38b
to
cec7692
Compare
dmitryax
approved these changes
Nov 21, 2024
@sfc-gh-sili please run |
Now |
songy23
added
the
ready-to-merge
Code review completed; ready to merge by maintainers
label
Nov 22, 2024
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR proceeds open-telemetry#11637. It * Introduces a noop feature gate that will be used for queue batcher. * Updates exporter tests to run with both the feature gate on and off. <!-- Issue number if applicable --> #### Link to tracking issue open-telemetry#10368 open-telemetry#8122 <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
Code review completed; ready to merge by maintainers
Skip Changelog
PRs that do not require a CHANGELOG.md entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR proceeds #11637. It
Link to tracking issue
#10368
#8122
Testing
Documentation