[interna/sharedcomponent] Use a ring buffer to restrict remembered status count #11826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11826 +/- ##
=======================================
Coverage 91.62% 91.62%
=======================================
Files 447 447
Lines 23729 23731 +2
=======================================
+ Hits 21741 21743 +2
Misses 1613 1613
Partials 375 375 ☔ View full report in Codecov by Sentry. |
bogdandrutu
reviewed
Dec 9, 2024
bogdandrutu
approved these changes
Dec 9, 2024
TylerHelmuth
added
the
ready-to-merge
|
@TylerHelmuth Ready to merge once you fix the merge conflicts |
codeboten
approved these changes
Dec 18, 2024
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
…atus count (open-telemetry#11826) #### Description Use a ring buffer to only remember the last 5 events. This ensures we remember a reasonable number of events during startup, so that a status aggregator gets the events for all instances. Then during normal operation, when we're done adding sources and no longer need to replay events, we don't have to remember every single event. #### Link to tracking issue Closes open-telemetry#11818 #### Testing `go test status_test.go -count 1000 -failfast` still passes with many tries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use a ring buffer to only remember the last 5 events. This ensures we remember a reasonable number of events during startup, so that a status aggregator gets the events for all instances. Then during normal operation, when we're done adding sources and no longer need to replay events, we don't have to remember every single event.
Link to tracking issue
Closes #11818
Testing
go test status_test.go -count 1000 -failfaststill passes with many tries.