Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fix CI checks job #11880

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

dmitryax
Copy link
Member

If we run our CI with go-version: ~1.22.9, we would need to update the toolchain every time minor go version is released to make the checks CI job pass

We probably should do something else with this

If we run our CI with `go-version: ~1.22.9`, we would need to update the toolchain every time minor go version is released to make the `checks` CI job pass
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.59%. Comparing base (63d83d5) to head (c4b53f9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11880   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files         449      449           
  Lines       23761    23761           
=======================================
  Hits        21763    21763           
  Misses       1623     1623           
  Partials      375      375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten added this pull request to the merge queue Dec 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 13, 2024
@dmitryax dmitryax added this pull request to the merge queue Dec 13, 2024
Merged via the queue into open-telemetry:main with commit b028adc Dec 13, 2024
50 checks passed
@dmitryax dmitryax deleted the fix-check-ci branch December 13, 2024 17:31
@github-actions github-actions bot added this to the next release milestone Dec 13, 2024
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
If we run our CI with `go-version: ~1.22.9`, we would need to update the
toolchain every time minor go version is released to make the `checks`
CI job pass

We probably should do something else with this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants