Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate connectorprofiles module in favor of xconnector #11887

Merged

Conversation

dmitryax
Copy link
Member

to allow adding more experimental data types.

Updates #11778

@songy23 songy23 added the release:blocker The issue must be resolved before cutting the next release label Dec 13, 2024
@dmitryax dmitryax force-pushed the deprecated-connectorprofiles-module branch 2 times, most recently from ff7e17c to aaf9831 Compare December 13, 2024 21:58
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 77.24551% with 38 lines in your changes missing coverage. Please review.

Project coverage is 91.59%. Comparing base (7941703) to head (4789e95).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
connector/xconnector/connector.go 72.09% 36 Missing ⚠️
connector/connectortest/connector.go 80.00% 1 Missing ⚠️
connector/xconnector/profiles_router.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11887   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files         449      449           
  Lines       23761    23761           
=======================================
  Hits        21763    21763           
  Misses       1623     1623           
  Partials      375      375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax dmitryax force-pushed the deprecated-connectorprofiles-module branch 5 times, most recently from 26a96c3 to 7a73afa Compare December 14, 2024 03:02
@songy23
Copy link
Member

songy23 commented Dec 14, 2024

Missing some import & linter issues https://github.com/open-telemetry/opentelemetry-collector/actions/runs/12326293538/job/34406867175?pr=11887

@dmitryax dmitryax force-pushed the deprecated-connectorprofiles-module branch 2 times, most recently from 76c2d0d to 668056a Compare December 14, 2024 05:03
to allow adding more experimental data types.
@dmitryax dmitryax force-pushed the deprecated-connectorprofiles-module branch from 668056a to 4789e95 Compare December 14, 2024 05:08
@dmitryax dmitryax enabled auto-merge December 14, 2024 05:10
@dmitryax dmitryax added this pull request to the merge queue Dec 14, 2024
Merged via the queue into open-telemetry:main with commit e9bc4bd Dec 14, 2024
49 of 50 checks passed
@dmitryax dmitryax deleted the deprecated-connectorprofiles-module branch December 14, 2024 15:24
@github-actions github-actions bot added this to the next release milestone Dec 14, 2024
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:blocker The issue must be resolved before cutting the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants