Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate processorhelperprofiles module in favor of xprocessorhelper #11889

Merged

Conversation

dmitryax
Copy link
Member

to allow adding more experimental data types

Updates #11778

@dmitryax dmitryax requested a review from a team as a code owner December 13, 2024 23:15
@dmitryax dmitryax requested a review from jpkrohling December 13, 2024 23:15
@dmitryax dmitryax added the release:blocker The issue must be resolved before cutting the next release label Dec 13, 2024
@dmitryax
Copy link
Member Author

I'm putting the release:blocker label with an intention to deprecate all the modules before the next release. Technically, it's not a blocker

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.59%. Comparing base (0d94e09) to head (eee3b96).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...essor/processorhelper/xprocessorhelper/profiles.go 85.71% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11889   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files         449      449           
  Lines       23761    23761           
=======================================
  Hits        21763    21763           
  Misses       1623     1623           
  Partials      375      375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax dmitryax enabled auto-merge December 14, 2024 01:42
@dmitryax dmitryax added this pull request to the merge queue Dec 14, 2024
Merged via the queue into open-telemetry:main with commit 7941703 Dec 14, 2024
53 of 68 checks passed
@dmitryax dmitryax deleted the deprecate-processorhelperprofiles branch December 14, 2024 05:04
@github-actions github-actions bot added this to the next release milestone Dec 14, 2024
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:blocker The issue must be resolved before cutting the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants