Switch to using perf counters to get disk io metrics on Windows #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bebbington
requested review from
bogdandrutu,
dmitryax,
flands,
owais,
pjanotti,
rghetia and
tigrannajaryan
as code owners
james-bebbington
force-pushed
the
disk-perf
branch
3 times, most recently
from
009be48
to
b2e0e7f
Compare
Codecov Report
@@ Coverage Diff @@
## master #1340 +/- ##
=======================================
Coverage 90.14% 90.14%
=======================================
Files 218 218
Lines 15256 15256
=======================================
Hits 13752 13752
Misses 1095 1095
Partials 409 409
Continue to review full report at Codecov.
|
james-bebbington
force-pushed
the
disk-perf
branch
from
b2e0e7f
to
726185d
Compare
james-bebbington
force-pushed
the
disk-perf
branch
from
726185d
to
bd9a0f0
Compare
bogdandrutu
approved these changes
Jul 15, 2020
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Add TraceState to API * Add tests for TraceState * Update related tests - stdout exporter test - SDK test * Update OTLP span transform * Update CHANGELOG * Change TraceState to struct instead of pointer - Adjust tests for trace API - Adjust adjacent parts of codebase (test utils, SDK etc.) * Add methods to assert equality - for type SpanContext, if SpanID, TraceID, TraceFlag and TraceState are equal - for type TraceState, if entries of both respective trace states are equal Signed-off-by: Matej Gera <matejgera@gmail.com> * Copy values for new TraceState, adjust tests * Use IsEqualWith in remaining tests instead of assertion func * Further feedback, minor improvements - Move IsEqualWith method to be only in test package - Minor improvements, typos etc. Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Disk IO stats returned by gopsutil on Windows are dependent on the drive configuration and don't always work (e.g. doesn't work on EC2 or GCE). Even if we fixed this to work like psutil, the drive descriptions will show as PhysicalDisk[0-26] instead of reflecting the associated partition mounts [A-Z]: and there is no straightforward way to show a more user friendly name.
Without any better alternative, this PR reverts to getting Disk IO stats from performance counters on Windows. There doesn't seem to be a performance counter for "Disk Time" so ignoring that for now.
Note this PR renames the
disk_scraper.gotodisk_scraper_others.go(otherwise unchanged) & puts that behind a!windowsbuild flag. We then add a separate scraper for windows,disk_scraper_windows.go, with an implementation using perf counters.