Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generating metric data for testing #1398

Merged
merged 3 commits into from
Jul 20, 2020
Merged

Add support for generating metric data for testing #1398

merged 3 commits into from
Jul 20, 2020

Conversation

pmcollins
Copy link
Member

@pmcollins pmcollins commented Jul 20, 2020

This is in support of issue #652 and in response to a request by the team to break up my last commit into smaller chunks. This is the first of those chunks.

We will need to generate MetricData content both for feeding to the testbed sender and for testing MetricData diff functionality which will be used for validation checking in the testbed.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding extra fields can be done in a followup PR.

internal/goldendataset/metric_gen.go Show resolved Hide resolved
internal/goldendataset/metric_gen.go Outdated Show resolved Hide resolved
internal/goldendataset/metric_gen.go Outdated Show resolved Hide resolved
internal/goldendataset/metric_gen.go Show resolved Hide resolved
internal/goldendataset/metric_gen.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 20, 2020

Codecov Report

Merging #1398 into master will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1398      +/-   ##
==========================================
+ Coverage   90.50%   90.59%   +0.09%     
==========================================
  Files         219      220       +1     
  Lines       15521    15658     +137     
==========================================
+ Hits        14047    14186     +139     
+ Misses       1060     1059       -1     
+ Partials      414      413       -1     
Impacted Files Coverage Δ
internal/goldendataset/metric_gen.go 100.00% <100.00%> (ø)
receiver/otlpreceiver/otlp.go 90.47% <0.00%> (-3.18%) ⬇️
translator/internaldata/resource_to_oc.go 86.04% <0.00%> (+4.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc89783...f9d6a4d. Read the comment docs.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit

internal/goldendataset/metric_gen.go Outdated Show resolved Hide resolved
@bogdandrutu bogdandrutu merged commit dcf59b3 into open-telemetry:master Jul 20, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
…jaeger (open-telemetry#1398)

* Bump google.golang.org/api in /exporters/trace/jaeger

Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.32.0 to 0.36.0.
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/master/CHANGES.md)
- [Commits](googleapis/google-api-go-client@v0.32.0...v0.36.0)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants