Generate metric data from PICT files #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmcollins
requested review from
bogdandrutu,
dmitryax,
flands,
james-bebbington,
owais,
pjanotti,
rghetia and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1414 +/- ##
==========================================
+ Coverage 90.28% 90.33% +0.05%
==========================================
Files 232 233 +1
Lines 16396 16447 +51
==========================================
+ Hits 14803 14858 +55
+ Misses 1136 1134 -2
+ Partials 457 455 -2
Continue to review full report at Codecov.
|
| require.Equal(t, 19, len(mds)) | ||
| } | ||
|
|
||
| func TestPICTtoCfg0(t *testing.T) { |
There was a problem hiding this comment.
Oops, that's vestigial. Fixed.
rmfitzpatrick
approved these changes
Jul 27, 2020
bogdandrutu
approved these changes
Jul 27, 2020
| @@ -54,7 +54,7 @@ func DefaultCfg() MetricCfg { | |||
| NumILMPerResource: 1, | |||
| NumMetricsPerILM: 1, | |||
| NumPtLabels: 1, | |||
| NumPts: 1, | |||
| NumPtsPerMetric: 1, | |||
There was a problem hiding this comment.
In the future, these kind of changes can be split in small trivial to review PRs :)
6 tasks
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
…rters/metric/prometheus (open-telemetry#1414) * Bump github.com/prometheus/client_golang in /exporters/metric/prometheus Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.8.0 to 1.9.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/master/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.8.0...v1.9.0) Signed-off-by: dependabot[bot] <support@github.com> * Auto-fix go.sum changes in dependent modules Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
* Enable Cloud Foundry receiver The Cloud Foundry receiver has been enabled in the OpenTelementry Collector Contrib repository, and is now supported. This receiver should also be supported in the Splunk distribution. This change adds it as a dependency, adds it to the list of valid receivers, and adds a reference to documentation, and the CHANGELOG.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in support of issue #652 and in response to a request by the team to break a large PR into smaller chunks.
This change adds support for producing MetricData from generated PICT files.