Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call combine error without checking for errors size #1443

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

bogdandrutu
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #1443 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1443      +/-   ##
==========================================
+ Coverage   90.78%   90.83%   +0.04%     
==========================================
  Files         234      234              
  Lines       16496    16468      -28     
==========================================
- Hits        14976    14958      -18     
+ Misses       1087     1082       -5     
+ Partials      433      428       -5     
Impacted Files Coverage Δ
component/componenterror/errors.go 100.00% <100.00%> (ø)
...ceiver/hostmetricsreceiver/hostmetrics_receiver.go 88.13% <100.00%> (-0.39%) ⬇️
...al/scraper/filesystemscraper/filesystem_scraper.go 100.00% <100.00%> (ø)
...internal/scraper/networkscraper/network_scraper.go 100.00% <100.00%> (ø)
...internal/scraper/processscraper/process_scraper.go 98.33% <100.00%> (-0.06%) ⬇️
...nternal/scraper/swapscraper/swap_scraper_others.go 100.00% <100.00%> (ø)
service/builder/exporters_builder.go 73.91% <100.00%> (+1.05%) ⬆️
service/builder/extensions_builder.go 84.61% <100.00%> (+4.90%) ⬆️
service/builder/pipelines_builder.go 82.78% <100.00%> (+1.08%) ⬆️
service/builder/receivers_builder.go 74.85% <100.00%> (+0.86%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2b2aed...fe46e3a. Read the comment docs.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 600fd5f into open-telemetry:master Jul 27, 2020
@bogdandrutu bogdandrutu deleted the errors branch July 27, 2020 20:17
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
…sor (open-telemetry#1443)

* Fix BatchSpanProcessor does not shutdown underlying span exporter

* Update CHANGELOG

* Fix tests

* Update CHANGELOG.md
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants