Enable queueing, retry, timeout for Kafka exporter #1455

bogdandrutu · 2020-07-29T14:45:18Z

codecov · 2020-07-29T14:52:34Z

Codecov Report

Merging #1455 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1455   +/-   ##
=======================================
  Coverage   90.93%   90.93%           
=======================================
  Files         240      240           
  Lines       16718    16727    +9     
=======================================
+ Hits        15202    15211    +9     
  Misses       1085     1085           
  Partials      431      431

Impacted Files	Coverage Δ
exporter/kafkaexporter/factory.go	`100.00% <100.00%> (ø)`
exporter/kafkaexporter/kafka_exporter.go	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d31f0f...90d64b1. Read the comment docs.

exporter/kafkaexporter/kafka_exporter_test.go

pavolloffay · 2020-07-29T15:17:14Z

exporter/kafkaexporter/kafka_exporter.go

@@ -41,6 +41,8 @@ func newExporter(config Config, params component.ExporterCreateParams) (*kafkaPr
 	c.Producer.Return.Errors = true
 	// Wait only the local commit to succeed before responding.
 	c.Producer.RequiredAcks = sarama.WaitForLocal
+	// Because sarama does not accept a Context for every message, set the Timeout here.


not sure what you mean by a Context

SendRequest does not accept a context.Context as an argument, so I cannot pass Timeout using the standard go way to do this via the context.Context

pavolloffay · 2020-07-29T15:20:36Z

exporter/kafkaexporter/config_test.go

+		},
+		QueueSettings: exporterhelper.QueueSettings{
+			Enabled:      true,
+			NumConsumers: 2,


Shouldn't this be one?

Should it? it is 2 here because that's what I put in the yaml.

Looks good I haven't noticed that this is a test 😟

pavolloffay · 2020-07-29T15:22:05Z

exporter/kafkaexporter/config_test.go

+			MaxInterval:     1 * time.Minute,
+			MaxElapsedTime:  10 * time.Minute,
+		},
+		QueueSettings: exporterhelper.QueueSettings{


Are the default values based on something or just common sense (also for the retry) ?

Just common sense. there is a documentation on how to configure the sending queue:
https://github.com/open-telemetry/opentelemetry-collector/blob/master/exporter/exporterhelper/queued_retry.go#L43

pavolloffay · 2020-07-29T16:07:24Z

Could you please also update the readme with the new properties?

bogdandrutu · 2020-07-29T17:48:47Z

@pavolloffay PTAL

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

pavolloffay

LGTM, although I am not sure what the default values should be used.

pavolloffay · 2020-07-30T06:55:15Z

exporter/kafkaexporter/README.md

+- `timeout` (default = 5s): Is the timeout for every attempt to send data to the backend.
+- `retry_on_failure`
+  - `enabled` (default = true)
+  - `initial_interval` (default = 5s): Time to wait after the first failure before retrying; ignored if `enabled` is `false`


Are the default values correct? Shouldn't we use the same defaults as the driver uses?

https://github.com/Shopify/sarama/blob/master/config.go#L462

You pointed to the timeout this is the initial backoff delay after a request fail. We can tune the timeout to be 10sec if that is important, I would leave it as is for the moment and maybe collect feedback.

pavolloffay · 2020-07-30T06:55:41Z

exporter/kafkaexporter/README.md

+  - `max_elapsed_time` (default = 120s): Is the maximum amount of time spent trying to send a batch; ignored if `enabled` is `false`
+- `sending_queue`
+  - `enabled` (default = false)
+  - `num_consumers` (default = 10): Number of consumers that dequeue batches; ignored if `enabled` is `false`


Does it mean that 10 instances of the exporter will be created?

Just one instance, but will be 10 goroutines consuming items from the in-memory queue (similar with queue retry processor, but per exporter) and calling into the only one instance of the exporter created.

bogdandrutu · 2020-08-04T02:21:30Z

/cc @tigrannajaryan

tigrannajaryan · 2020-08-13T18:59:10Z

exporter/kafkaexporter/config.go

+	exporterhelper.TimeoutSettings `mapstructure:",squash"` // squash ensures fields are correctly decoded in embedded struct.
+	exporterhelper.QueueSettings   `mapstructure:"sending_queue"`
+	exporterhelper.RetrySettings   `mapstructure:"retry_on_failure"`


Since all (?) of the exporters are going to need all 3 settings perhaps introduce a struct which embeds all 3 and use. Can be done in a future PR.

…lemetry#1455) * Bump github.com/stretchr/testify from 1.6.1 to 1.7.0 in /sdk Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.6.1 to 1.7.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.6.1...v1.7.0) Signed-off-by: dependabot[bot] <support@github.com> * Auto-fix go.sum changes in dependent modules Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

…y#1455) Bumps [boto3](https://github.com/boto/boto3) from 1.21.35 to 1.21.38. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.21.35...1.21.38) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

bogdandrutu requested review from dmitryax, james-bebbington, nilebox, owais, pjanotti and tigrannajaryan as code owners July 29, 2020 14:45

pavolloffay reviewed Jul 29, 2020

View reviewed changes

bogdandrutu force-pushed the kafkaexp branch from 1e0c8f9 to 8d00324 Compare July 29, 2020 17:48

Enable queueing, retry, timeout for Kafka exporter

90d64b1

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

bogdandrutu force-pushed the kafkaexp branch from 8d00324 to 90d64b1 Compare July 29, 2020 18:10

pavolloffay approved these changes Jul 30, 2020

View reviewed changes

bogdandrutu assigned tigrannajaryan Aug 4, 2020

tigrannajaryan approved these changes Aug 13, 2020

View reviewed changes

tigrannajaryan merged commit 442c6df into open-telemetry:master Aug 13, 2020

bogdandrutu deleted the kafkaexp branch September 14, 2020 17:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable queueing, retry, timeout for Kafka exporter #1455

Enable queueing, retry, timeout for Kafka exporter #1455

bogdandrutu commented Jul 29, 2020 •

edited

Loading

codecov bot commented Jul 29, 2020 •

edited

Loading

pavolloffay Jul 29, 2020

bogdandrutu Jul 29, 2020

pavolloffay Jul 29, 2020

bogdandrutu Jul 29, 2020

pavolloffay Jul 30, 2020

pavolloffay Jul 29, 2020

bogdandrutu Jul 29, 2020

pavolloffay commented Jul 29, 2020

bogdandrutu commented Jul 29, 2020

pavolloffay left a comment

pavolloffay Jul 30, 2020

bogdandrutu Jul 30, 2020

pavolloffay Jul 30, 2020

bogdandrutu Jul 30, 2020

bogdandrutu commented Aug 4, 2020

tigrannajaryan Aug 13, 2020

Enable queueing, retry, timeout for Kafka exporter #1455

Enable queueing, retry, timeout for Kafka exporter #1455

Conversation

bogdandrutu commented Jul 29, 2020 • edited Loading

codecov bot commented Jul 29, 2020 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pavolloffay commented Jul 29, 2020

bogdandrutu commented Jul 29, 2020

pavolloffay left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bogdandrutu commented Aug 4, 2020

Choose a reason for hiding this comment

bogdandrutu commented Jul 29, 2020 •

edited

Loading

codecov bot commented Jul 29, 2020 •

edited

Loading