Add new FactoryUnmarshaler support to all components, deprecate old way #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
bogdandrutu
changed the title
bogdandrutu
force-pushed
the
custom
branch
2 times, most recently
from
097d59d
to
72efdeb
Compare
Codecov Report
@@ Coverage Diff @@
## master #1468 +/- ##
==========================================
+ Coverage 90.95% 90.96% +0.01%
==========================================
Files 239 239
Lines 16711 16737 +26
==========================================
+ Hits 15199 15225 +26
+ Misses 1083 1082 -1
- Partials 429 430 +1
Continue to review full report at Codecov.
|
nilebox
reviewed
Aug 3, 2020
bogdandrutu
force-pushed
the
custom
branch
5 times, most recently
from
4409737
to
16fd7b6
Compare
nilebox
reviewed
Aug 4, 2020
tigrannajaryan
approved these changes
Aug 4, 2020
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
…emetry#1468) The main reason for the change is I'm trying to use this library with Bazel, using gazelle. Gazelle automates creation of the Bazel rules for a Go module. Gazelle assumes files ending in '.proto' are Protocol Buffer files and invokes protoc on the file to generate the Go code for the proto file. Unfortunately, protoc doesn't seem to like Makefiles. As a side-benefit, editors that don't support Emacs mode hints `-*- mode: makefile; -*-` won't try to highlight the Makefile as a protobuf file.
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…y#1468) Bumps [boto3](https://github.com/boto/boto3) from 1.21.40 to 1.21.41. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.21.40...1.21.41) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #882 - need custom unmarshaler for the exporter to allow multi protocols support.
Fixes #292