Always include Zipkin's localEndpoint serviceName #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmm-sumo
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
|
|
|
/cc @kbrockhoff |
|
Seems that the previous CLA didn't get migrated, I will work on getting this fixed |
Codecov Report
@@ Coverage Diff @@
## master #1481 +/- ##
==========================================
+ Coverage 90.92% 90.95% +0.02%
==========================================
Files 239 239
Lines 16706 16709 +3
==========================================
+ Hits 15190 15197 +7
+ Misses 1085 1083 -2
+ Partials 431 429 -2
Continue to review full report at Codecov.
|
pjanotti
approved these changes
Aug 5, 2020
|
Thanks for the review and sorry for the delay with EasyCLA migration. Should be good now @bogdandrutu @pjanotti |
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
Based on its module, it should be go.opencensus.io/otel/example/opencensus. However, it's simpler to get rid of it since main packages shouldn't be imported at all. Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes a bug with service name being skipped when span contains no attributes
Link to tracking Issue: #1480
Testing: Added unit test and tested manually
Documentation: No extra documentation added