Increase max wait time on host metrics test #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bebbington
requested review from
bogdandrutu,
dmitryax,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
bogdandrutu
approved these changes
Aug 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #1510 +/- ##
==========================================
+ Coverage 91.27% 91.32% +0.04%
==========================================
Files 240 240
Lines 16719 16719
==========================================
+ Hits 15261 15269 +8
+ Misses 1047 1043 -4
+ Partials 411 407 -4
Continue to review full report at Codecov.
|
|
Not sure why build-and-test is showing up up twice in the build Checks. The build is succeeding but the earlier (transient) failure won't go away |
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows CI sees this test fail very occasionally, presumably because system metric collection is slow (lots of processes running or sys calls blocked for some reason). Try increasing the max wait time before resorting to anything more drastic.
Resolves: #1445 (comment)