Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change OpenCensus receiver to the new interfaces #1556

Merged
merged 1 commit into from
Aug 17, 2020

Conversation

bogdandrutu
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 15, 2020

Codecov Report

Merging #1556 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1556      +/-   ##
==========================================
+ Coverage   91.46%   91.47%   +0.01%     
==========================================
  Files         250      250              
  Lines       17315    17319       +4     
==========================================
+ Hits        15837    15843       +6     
+ Misses       1063     1062       -1     
+ Partials      415      414       -1     
Impacted Files Coverage Δ
receiver/opencensusreceiver/opencensus.go 90.09% <ø> (ø)
receiver/opencensusreceiver/factory.go 95.45% <100.00%> (+0.45%) ⬆️
...eceiver/opencensusreceiver/ocmetrics/opencensus.go 90.47% <100.00%> (ø)
receiver/opencensusreceiver/octrace/opencensus.go 83.33% <100.00%> (ø)
service/defaultcomponents/defaults.go 84.90% <100.00%> (ø)
receiver/otlpreceiver/otlp.go 91.66% <0.00%> (-2.78%) ⬇️
translator/internaldata/resource_to_oc.go 83.33% <0.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa62be6...07a1d26. Read the comment docs.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Do we have any old trace consumers remaining in the codebase or everything is now converted?

@bogdandrutu
Copy link
Member Author

@tigrannajaryan last one is the oc exporter, which I will do after #1516

@bogdandrutu bogdandrutu merged commit cb7a116 into open-telemetry:master Aug 17, 2020
@bogdandrutu bogdandrutu deleted the ocrecv branch August 17, 2020 18:41
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants