Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename some internal funcs to allow the oc to new structs to reuse the names #1664

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

bogdandrutu
Copy link
Member

Updates #1657

…e names

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #1664 into master will decrease coverage by 0.02%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1664      +/-   ##
==========================================
- Coverage   92.24%   92.21%   -0.03%     
==========================================
  Files         262      262              
  Lines       18765    18761       -4     
==========================================
- Hits        17309    17301       -8     
- Misses       1042     1044       +2     
- Partials      414      416       +2     
Impacted Files Coverage Δ
translator/internaldata/oc_to_old_metrics.go 88.88% <86.95%> (-0.23%) ⬇️
translator/internaldata/old_metrics_to_oc.go 91.54% <100.00%> (ø)
receiver/otlpreceiver/otlp.go 91.66% <0.00%> (-2.78%) ⬇️
translator/internaldata/resource_to_oc.go 87.03% <0.00%> (-1.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03faf67...f68eb7f. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 88634ae into open-telemetry:master Aug 28, 2020
@bogdandrutu bogdandrutu deleted the octonew branch August 28, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants