Report Windows pagefile usage in bytes #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bebbington
requested review from
bogdandrutu,
dmitryax,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
| @@ -54,7 +54,7 @@ var swapUsageDescriptor = func() pdata.Metric { | |||
| metric.InitEmpty() | |||
| metric.SetName("system.swap.usage") | |||
| metric.SetDescription("Swap (unix) or pagefile (windows) usage.") | |||
| metric.SetUnit("pages") | |||
| metric.SetUnit("bytes") | |||
There was a problem hiding this comment.
Updated as per open-telemetry/opentelemetry-specification#937 (comment)
Codecov Report
@@ Coverage Diff @@
## master #1837 +/- ##
=======================================
Coverage 91.12% 91.12%
=======================================
Files 263 263
Lines 16105 16105
=======================================
Hits 14675 14675
Misses 1003 1003
Partials 427 427
Continue to review full report at Codecov.
|
Comment on lines
+56
to
+57
| usedPages uint64 | ||
| totalPages uint64 |
|
|
||
| func getPageSize() uint64 { | ||
| var sysInfo systemInfo | ||
| procGetNativeSystemInfo.Call(uintptr(unsafe.Pointer(&sysInfo))) |
There was a problem hiding this comment.
GetNativeSystemInfo doesn't return error or sets last error per https://docs.microsoft.com/en-us/windows/win32/api/sysinfoapi/nf-sysinfoapi-getnativesysteminfo
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Prepare for releasing v0.20.0 * Update changelog * Add version validation test * lint
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…metry#1837) Bumps [github.com/jaegertracing/jaeger](https://github.com/jaegertracing/jaeger) from 1.36.0 to 1.37.0. - [Release notes](https://github.com/jaegertracing/jaeger/releases) - [Changelog](https://github.com/jaegertracing/jaeger/blob/main/CHANGELOG.md) - [Commits](jaegertracing/jaeger@v1.36.0...v1.37.0) --- updated-dependencies: - dependency-name: github.com/jaegertracing/jaeger dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code inconsistently reports pagefile usage in pages on Windows and swap usage in bytes on Unix systems.
Updated the code to convert from pages to bytes on Windows so this is consistent.